Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0 forwardport #1472

Merged
merged 4 commits into from
Apr 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: 11
java-version: 17
distribution: 'temurin'
cache: gradle
- uses: actions/cache@v3
Expand All @@ -39,10 +39,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: 11
java-version: 17
distribution: 'temurin'
cache: gradle
- uses: actions/cache@v3
Expand All @@ -65,10 +65,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: 11
java-version: 17
distribution: 'temurin'
cache: gradle
- uses: actions/cache@v3
Expand All @@ -91,10 +91,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: 11
java-version: 17
distribution: 'temurin'
cache: gradle
- uses: actions/cache@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gradlepublish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: 11
java-version: 17
distribution: 'temurin'
cache: gradle
- name: Gradle wrapper
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gradlepublishalpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: 11
java-version: 17
distribution: 'temurin'
cache: gradle
- name: Gradle wrapper
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@

## Works with

* PhpStorm >= 2021.2.1
* JRE >= 11
* PhpStorm >= 2023.1
* JRE >= 17

## Features

Expand Down
14 changes: 7 additions & 7 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

plugins {
id 'org.jetbrains.intellij' version '1.13.2'
id 'org.jetbrains.intellij' version '1.13.3'
id 'checkstyle'
id 'pmd'
id 'org.jetbrains.changelog' version '2.0.0'
Expand All @@ -23,9 +23,9 @@ apply plugin: 'idea'
apply plugin: 'groovy'
apply plugin: 'org.jetbrains.changelog'

def phpPluginVersion = System.getProperty("phpPluginVersion", "222.3739.45")
def ideaVersion = System.getProperty("ideaVersion", "2022.2.1")
def javaVersion = 11
def phpPluginVersion = System.getProperty("phpPluginVersion", "231.8109.199")
def ideaVersion = System.getProperty("ideaVersion", "2023.1")
def javaVersion = 17

sourceCompatibility = javaVersion
targetCompatibility = javaVersion
Expand All @@ -39,9 +39,9 @@ intellij {
'yaml',
'java-i18n',
'properties',
'CSS',
'JavaScriptLanguage',
'com.intellij.lang.jsgraphql:3.2.1',
'com.intellij.css',
'JavaScript',
'com.intellij.lang.jsgraphql:3.4.0',
'platform-images',
'copyright'
]
Expand Down
3 changes: 2 additions & 1 deletion resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</change-notes>

<!-- please see http://confluence.jetbrains.com/display/IDEADEV/Build+Number+Ranges for description -->
<idea-version since-build="222.3739.54"/>
<idea-version since-build="231.8109.175"/>

<!-- please see http://confluence.jetbrains.com/display/IDEADEV/Plugin+Compatibility+with+IntelliJ+Platform+Products
on how to target different products -->
Expand All @@ -33,6 +33,7 @@
-->
<depends>com.jetbrains.php</depends>
<depends>JavaScript</depends>
<depends>com.intellij.css</depends>
<depends>com.intellij.modules.platform</depends>
<depends>com.intellij.platform.images</depends>
<depends>com.intellij.copyright</depends>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
import com.intellij.ide.actions.NonTrivialActionGroup;
import com.intellij.openapi.util.IconLoader;
import com.magento.idea.magento2plugin.MagentoIcons;
import javax.swing.Icon;
import org.jetbrains.annotations.NotNull;

public class NewEavAttributeGroup extends NonTrivialActionGroup {

Expand All @@ -19,12 +17,8 @@ public class NewEavAttributeGroup extends NonTrivialActionGroup {
public NewEavAttributeGroup() {
super();

this.getTemplatePresentation().setIcon(new IconLoader.LazyIcon() {
@NotNull
@Override
protected Icon compute() {
return MagentoIcons.MODULE;
}
});
this.getTemplatePresentation().setIcon(
IconLoader.createLazy(() -> MagentoIcons.MODULE)
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.PlatformDataKeys;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.IconLoader.LazyIcon;
import com.intellij.openapi.util.IconLoader;
import com.intellij.psi.PsiDirectory;
import com.intellij.psi.PsiElement;
import com.magento.idea.magento2plugin.MagentoIcons;
Expand All @@ -18,8 +18,6 @@
import com.magento.idea.magento2plugin.project.Settings;
import com.magento.idea.magento2plugin.util.magento.GetMagentoModuleUtil;
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
import javax.swing.Icon;
import org.jetbrains.annotations.NotNull;

public class NewModuleFileGroup extends NonTrivialActionGroup {

Expand All @@ -29,13 +27,9 @@ public class NewModuleFileGroup extends NonTrivialActionGroup {
public NewModuleFileGroup() {
super();

this.getTemplatePresentation().setIcon(new LazyIcon() {
@NotNull
@Override
protected Icon compute() {
return MagentoIcons.MODULE;
}
});
this.getTemplatePresentation().setIcon(
IconLoader.createLazy(() -> MagentoIcons.MODULE)
);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public void actionPerformed(@NotNull AnActionEvent e) {
}

private static boolean isInIncludePath(@NotNull VirtualFile fileToCheck, @NotNull Project project) {
List<VirtualFile> includePaths = PhpIncludePathManager.getInstance(project).getRoots();
List<VirtualFile> includePaths = PhpIncludePathManager.getInstance(project).getAllIncludedRoots();
Iterator iterator = includePaths.iterator();

VirtualFile file;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ protected void assertHasNoLinemarkerWithTooltipAndIcon(
= "Failed that documents not contains linemarker with the tooltip `%s`";

final List<LineMarkerInfo<?>> lineMarkers = getDocumentLineMarkers();
assertNotEmpty(lineMarkers);
for (final LineMarkerInfo lineMarkerInfo: lineMarkers) {
final String lineMarkerTooltip = lineMarkerInfo.getLineMarkerTooltip();
final Icon lineMarkerIcon = lineMarkerInfo.getIcon();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public class GraphQlResolverClassLinemarkerRegistrarTest extends LinemarkerFixtu
public void testWithValidSchemaResolver() {
myFixture.configureByFile(this.getFixturePath("schema.graphqls", "graphqls"));

assertHasLinemarkerWithTooltipAndIcon("Navigate to class", "nodes/class.svg");
assertHasLinemarkerWithTooltipAndIcon("Navigate to class", "Class");
}
}