Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal actions for generating files #1307

Merged
merged 5 commits into from
Apr 15, 2023
Merged

Modal actions for generating files #1307

merged 5 commits into from
Apr 15, 2023

Conversation

YevhenZvieriev
Copy link
Contributor

@YevhenZvieriev YevhenZvieriev commented Feb 17, 2023

Added the ability to switch between files when creating files using the plugin
Changes have been made to files such as:
New Entity
New Layout
New Message Queue
New Observer
New Ui Component Form
New Ui Component Grid
For other files, this functionality is not needed

Magento.2.PHPStorm.plugin.mp4

Description (*)

Fixed Issues (if relevant)

  1. Fixes magento/magento2-phpstorm-plugin#<issue_number>

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko VitaliyBoyko changed the base branch from 5.1.0-develop to 5.2.0-develop April 15, 2023 09:27
@YevhenZvieriev YevhenZvieriev changed the base branch from 5.2.0-develop to 5.1.1-develop April 15, 2023 10:05
@YevhenZvieriev YevhenZvieriev changed the base branch from 5.1.1-develop to 5.2.0-develop April 15, 2023 10:09
@VitaliyBoyko
Copy link
Contributor

Could you please implement this for the New Data Model dialog?

@YevhenZvieriev
Copy link
Contributor Author

Could you please implement this for the New Data Model dialog?

Yes, sure

@YevhenZvieriev
Copy link
Contributor Author

YevhenZvieriev commented Apr 15, 2023

Could you please implement this for the New Data Model dialog?

I did it in the c0d2897 commit but I want to attract your attention to these warnings:

"Warning:(81, 20) Private field 'modelNameErrorMessage' is never used" and
"Warning:(301,44) Statement lambda can be replaced with the expression lambda in the NewDataModelDialog.java file".

I suggest you remove this variable, if it doesn`t use.

@VitaliyBoyko VitaliyBoyko changed the title Added the ability to switch between files when creating files Modal actions for generating files Apr 15, 2023
@VitaliyBoyko VitaliyBoyko merged commit caa42ae into magento:5.2.0-develop Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants