Added Magento 2 module project template #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduard13
requested changes
Apr 9, 2020
There was a problem hiding this comment.
Hi @VitaliyBoyko, could you please review the below comments?
Thank you for the improvement.
| import org.jetbrains.annotations.Nls; | ||
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
...om/magento/idea/magento2plugin/actions/generation/generator/ModuleComposerJsonGenerator.java
Outdated
Show resolved
Hide resolved
| @@ -32,4 +35,6 @@ public String getModuleName() { | |||
| public PsiDirectory getBaseDir() { | |||
| return this.baseDir; | |||
| } | |||
|
|
|||
| public boolean getCreateModuleDirs() { return this.createModuleDirs; } | |||
There was a problem hiding this comment.
Please avoid inline methods.
Suggested change
| public boolean getCreateModuleDirs() { return this.createModuleDirs; } | |
| public boolean getCreateModuleDirs() { | |
| return this.createModuleDirs; | |
| } |
| @@ -32,4 +35,6 @@ public String getModuleName() { | |||
| public PsiDirectory getBaseDir() { | |||
| return this.baseDir; | |||
| } | |||
|
|
|||
| public boolean getCreateModuleDirs() { return this.createModuleDirs; } | |||
There was a problem hiding this comment.
Please avoid inline methods.
Suggested change
| public boolean getCreateModuleDirs() { return this.createModuleDirs; } | |
| public boolean getCreateModuleDirs() { | |
| return this.createModuleDirs; | |
| } |
| @@ -68,4 +71,7 @@ public String getModuleVersion() { | |||
| public List<String> getModuleDependencies() { | |||
| return moduleDependencies; | |||
| } | |||
|
|
|||
| public boolean getCreateModuleDirs() { return this.createModuleDirs; } | |||
There was a problem hiding this comment.
Please avoid inline methods.
Suggested change
| public boolean getCreateModuleDirs() { return this.createModuleDirs; } | |
| public boolean getCreateModuleDirs() { | |
| return this.createModuleDirs; | |
| } |
| Function[] functions = actions; | ||
| int length = actions.length; | ||
|
|
||
| for(int i = 0; i < length; ++i) { |
There was a problem hiding this comment.
Suggested change
| for(int i = 0; i < length; ++i) { | |
| for (int i = 0; i < length; ++i) { |
|
|
||
| @NotNull | ||
| public PhpFrameworkConfigurable createConfigurable(@NotNull Project project) { | ||
|
|
| } | ||
|
|
||
| public boolean isEnabled(@NotNull Project project) { | ||
|
|
| return VfsUtil.findRelativeFile(file, Package.APP, Package.MODULE_BASE_AREA_DIR, ModuleDiXml.FILE_NAME) != null && | ||
| VfsUtil.findRelativeFile(file, new String[]{Package.VENDOR}) != null; | ||
| } else { | ||
| return false; |
There was a problem hiding this comment.
I believe that you may extract this return outside the else, and remove the else ramification.
| VirtualFile[] roots = contentRoots; | ||
| int length = contentRoots.length; | ||
|
|
||
| for(int i = 0; i < length; ++i) { |
There was a problem hiding this comment.
Suggested change
| for(int i = 0; i < length; ++i) { | |
| for (int i = 0; i < length; ++i) { |
added 2 commits
April 9, 2020 16:19
eduard13
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added project template for Magento 2 Module
Fixed Issues (if relevant)
Startup
Code generation
Include path suggestion
Include path confirmation
Result
Also adjusted configs and fixed bugs with action scopes.