Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1263 second code source directory #1297

Closed

Conversation

vitaliyboykocontributor
Copy link
Contributor

Fixed Issues (if relevant)

  1. Fixes Possibility to add second code source directory for modules local composer development using content root feature #1263

Questions or comments
Aded second code source directory for module developers
Screenshot from 2023-02-05 19-21-40

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@nfourteen
Copy link

This would be really useful as I develop personal projects in a modules directory to force composer-bound modules and promote better tracking of hard/soft dependencies. Using composer config repositories.modules path "modules/*/*", sort of acts like modman, but uses git to manage modules.

Any chance this PR will make it into 5.2?

@drpayyne
Copy link
Contributor

Hi @vitaliyboykocontributor, just want to add my note that this feature is key for many developers. Is there something that's blocking the release of this feature? Thanks.

@ihor-sviziev
Copy link
Contributor

Just an idea for the future - maybe we can parce composer.json file, look for path repositories and auto-add them?

@VitaliyBoyko
Copy link
Contributor

@ihor-sviziev

This is an absolutely brilliant idea!

However, I can't promise when we’ll be able to implement it. There are a few reasons for this. Firstly, I don’t personally have a pressing need for this feature, which makes it challenging for me to find the motivation to prioritize its implementation. Over the past nine years of my career, I’ve always worked within the app/code structure, and that remains the case now.

If this feature is in high demand, I’d love to see someone take the initiative to work on it. I’d be more than happy to assist by covering QA and code reviews from my side.

At the moment, my focus is on addressing compatibility issues for 2025, so any help in pushing this forward would be greatly appreciated!

I am closing this PR as I love the proposed approach more.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 18, 2025

@VitaliyBoyko Another idea - @nfourteen, @drpayyne, what if you'll put all modules to app/code, configure composer to fetch packages from it with composer config repositories.modules path "app/code/*/*", and use it the same way as you're doing now with modules folder?
So that, we don't need to introduce any changes :)

@nfourteen
Copy link

nfourteen commented Feb 19, 2025

@ihor-sviziev Parsing composer.json is a great idea! As is configuring composer to use app/code. I hadn't tried the latter yet, but did move my modules to app/code to use the functionality of this plugin. I'll give configuring composer to use app/code a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants