Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] [Tests] Test coverage for PHP class completion for backend model; bugfix for #126 #127

Conversation

vasilii-b
Copy link

Description (*)

This PR

  1. covers with tests the PHP class completion for backend_model implemented in Completion. Add PHP classes completion to the backend_model attribute and tag #89
  2. refactor the test provided in 92 tests on php class completion for the source model #122 to match the new approach discussed with @VitaliyBoyko
  3. fix the bug reported in [bug] PHP classes completion to the backend_model attribute and tag not in the right files #126 and spotted during running the tests added in scope of this PR

successfull-tests-for-backend_model

refactored-test-successful-tests

Fixed Issues (if relevant)

  1. [bug] PHP classes completion to the backend_model attribute and tag not in the right files #126: PHP classes completion to the backend_model attribute and tag not in the right files
  2. Tests. Cover the "Add PHP classes completion to the backend_model attribute and tag" by tests #124: Tests. Cover the "Add PHP classes completion to the backend_model attribute and tag" by tests

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

Sorry, something went wrong.

Vasilii Burlacu added 2 commits April 8, 2020 19:16
Refactored the implementation for SourceModelXmlCompletionRegistrarTest.java to match the new pattern for test fixtures
Vitaliy Boyko added 2 commits April 9, 2020 16:50
@VitaliyBoyko VitaliyBoyko merged commit db49b23 into magento:1.0.0-develop Apr 9, 2020
@vasilii-b vasilii-b deleted the test-coverage-php-class-completion-for-backend_model branch April 9, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants