Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT custom coming versions #1251

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

makzef
Copy link

@makzef makzef commented Nov 24, 2022

Description (*)
Currently CLI UCT implementation uses hardcoded supported versions, which means it takes some time to add new version to the plugin codebase. This PR make able to run UCT for ever possible version.
More details on what was done:

  • Made editable combobox for coming version input.
  • Custom coming version will be save in configuration, also it will be available as an option when user previously save it in config.
  • Added regular expression (RegEx) to check a SemVer string for coming version input. User will see an error if format of version is incorrect.
  • Fix additional issue related to command parameter - module path.
uct_config.mov

Fixed Issues (if relevant)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@makzef makzef force-pushed the uct-custom-coming-versions branch from b680bc2 to 14e2259 Compare November 24, 2022 07:05
@bohdan-harniuk bohdan-harniuk self-requested a review November 24, 2022 12:05
@makzef makzef marked this pull request as draft November 24, 2022 14:40
@makzef makzef marked this pull request as ready for review November 24, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants