Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1224: Fixed compatibility issues by updating icon constants #1230

Merged

Conversation

makzef
Copy link

@makzef makzef commented Oct 13, 2022

Description (*)
Fixed several compatibility issues related to usage of unavailable icon constants.
In this PR was used icon constants that compatible with new version of IDE (currently Intellij IDEA 2022.3 EAP).

Some details about updated icons. For screenshots previous icons I use stable 4.4.0 version of plugin and new icons marked as 4.4.1-develop :

  1. PhpIcons.CLASS_ICONAllIcons.Nodes.Class
    4-4-0_php_class
    4-4-1-develop_php_class

  2. PhpIcons.XML_TAG_ICONAllIcons.Nodes.Tag
    4-4-0_xml_tag
    4-4-1-develop_xml_tag

  3. PhpIcons.Php_iconPhpIcons.PhpIcon
    PhpIcons.Php_icon is deprecated, if we look at the code we can see that PhpIcons.Php_icon just refers to PhpIcons.PhpIcon.
    php_icon
    4-4-1-develop_php_icon

Also made some code style improvements (checkstyles, etc.).

Fixed Issues (if relevant)

  1. Fixes Investigate and fix if possible compatibility problems with the PS 2022.3 (EAP) #1224

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @makzef !
Great work!
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants