Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1139: Creating a new observer template #1200

Conversation

anzin
Copy link
Contributor

@anzin anzin commented Sep 19, 2022

Description (*)

This pull request (PR) provides, creating a new observer template.

Screenshot 2022-09-19 at 18 09 22

Screenshot 2022-09-19 at 18 09 28

Screenshot 2022-09-19 at 18 10 28

Screenshot 2022-09-19 at 18 11 12

Screenshot 2022-09-19 at 18 11 18

Error message if specified patch name is already exist
Screenshot 2022-09-19 at 18 12 51

Fixed Issues (if relevant)

  1. Fixes [Generation] Add data patch and observer generators #1139

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@anzin anzin force-pushed the 1139-add-generator-to-create-observer-template branch from 3a78f5e to 13edf08 Compare September 19, 2022 15:35
@bohdan-harniuk bohdan-harniuk self-requested a review September 19, 2022 15:36
bohdan-harniuk
bohdan-harniuk previously approved these changes Sep 19, 2022
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @anzin!

Thank you for the great job!
I've refactored your code little bit. Please, read the changes.

Regards,

@bohdan-harniuk bohdan-harniuk merged commit fae3dc2 into magento:5.0.0-develop Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Generation] Add data patch and observer generators
2 participants