Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1135: Fixed issues with incorrect generation of resolver class #1192

Conversation

makzef
Copy link

@makzef makzef commented Sep 16, 2022

Description (*)

What were done:

  1. Added new inspection that shows warning about incorrect resolver class format (FQN).
  2. Fixed inspection that shows error message resolver class not exists for description values (in schema.graphqls file), but should only apply checks for class values.
  3. Added error message when user trying to create resolver that consists less than 3 parts of FQN. The class format should look like this: {VENDOR}\{MODULE}\{DIRECTORY OR DIRECTORIES OR NOTHING}\{CLASSFILE}, so only one part is optional - directory(-ies), that's why FQN should have minimum 3 parts.
  4. Fixed an issue when resolver file generated by incorrect path (related to directory creation described in scheme above), including incorrect file generation in the module root.
  5. Some code improvements related to above resolved issues.
graphql_resolver_class.mov

Fixed Issues (if relevant)

  1. Fixes [Bug] IndexOutOfBoundsException: CreateResolverClassQuickFix.applyFix(CreateResolverClassQuickFix.java:43) #1135

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@makzef makzef force-pushed the 1135-resolver-class-generation-issues branch from d314c51 to f268ef6 Compare September 16, 2022 10:11
@bohdan-harniuk bohdan-harniuk self-requested a review September 16, 2022 18:59
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @makzef!
Great work!
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants