Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1100: Added inspection to check if type attr value in the virtual type tag exists #1176

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)

Added inspection to check if type attribute value in the virtual type tag exists.

For an empty value:

Screenshot 2022-09-08 at 21 17 20

For an invalid value:

Screenshot 2022-09-08 at 21 17 01

For a valid value:

Screenshot 2022-09-08 at 21 16 51

Fixed Issues (if relevant)

  1. Fixes [Inspection] Add classes highlighting if class is not found on virtualType #1100

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk self-assigned this Sep 8, 2022
@bohdan-harniuk bohdan-harniuk force-pushed the 1100-add-virtual-type-class-existence-inspection branch from d1e3fd5 to cb47068 Compare September 8, 2022 18:23
@bohdan-harniuk bohdan-harniuk force-pushed the 1100-add-virtual-type-class-existence-inspection branch from cb47068 to 7e0ab87 Compare September 8, 2022 18:26
@Iamwade
Copy link
Collaborator

Iamwade commented Sep 9, 2022

Hi @bohdan-harniuk
Great job.
I have no questions about the code.
I did some local testing of the functionality for the frontend area. Everything works as described above.

For an empty value:
image

For an invalid value:
image

For a valid value:
image

Copy link
Collaborator

@Iamwade Iamwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inspection] Add classes highlighting if class is not found on virtualType
2 participants