1102: Fix bug create an observer #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk-through-the-context-menu
VitaliyBoyko
requested changes
Sep 7, 2022
| return true; | ||
| } | ||
|
|
||
| return PhpLangUtil.isFqn(targetClass.getFQN()) && !targetClass.getFQN().endsWith("\\"); |
There was a problem hiding this comment.
Why we don’t use here com.magento.idea.magento2plugin.actions.generation.generator.util.PhpClassGeneratorUtil#isValidFqn?
There was a problem hiding this comment.
Hello, @VitaliyBoyko, thank you for review,
I didn't use com.magento.idea.magento2plugin.actions.generation.generator.util.PhpClassGeneratorUtil#isValidFqn , because this method returns true when checking Fqn that ends with '\'
Thank you.
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: review
Progress: changes requested
labels
VitaliyBoyko
approved these changes
Sep 8, 2022
m2-community-project
bot
added
Progress: approved
Progress: done
and removed
Progress: review
labels
SilinMykola
pushed a commit
to SilinMykola/magento2-phpstorm-plugin
that referenced
this pull request
Sep 8, 2022
…er-not-work-through-the-context-menu 1102: Fix bug create an observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This pull request (PR) provides, fix bug create an observer for an event doesn't work through the context menu
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)