Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1128 fix bug with index in GitHubNewIssueBodyBuilderUtil class #1130

Conversation

SilinMykola
Copy link
Contributor

Description (*)
Added an additional check for string index in GitHubNewIssueBodyBuilderUtil class to prevent a StringIndexOutOfBoundsException

Fixed Issues (if relevant)

  1. Fixes [Bug] StringIndexOutOfBoundsException: GitHubNewIssueBodyBuilderUtil (stackTrace.substring(0, maxAllowedStackTraceLength - step)) #1128

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@SilinMykola SilinMykola force-pushed the 1128-fix-bug-with-index-in-GitHubNewIssueBodyBuilderUtil branch from bd404af to dcb5f76 Compare July 8, 2022 09:20
@bohdan-harniuk bohdan-harniuk self-requested a review July 28, 2022 12:14
…plugin into 1128-fix-bug-with-index-in-GitHubNewIssueBodyBuilderUtil
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix logic. It is wrong.

@SilinMykola SilinMykola force-pushed the 1128-fix-bug-with-index-in-GitHubNewIssueBodyBuilderUtil branch from 03e582c to 81d5d93 Compare July 28, 2022 12:41
@bohdan-harniuk bohdan-harniuk self-requested a review July 28, 2022 12:41
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SilinMykola !

Thank you for your work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants