Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1094 fix a new layout action error #1114

Merged

Conversation

SilinMykola
Copy link
Contributor

Description (*)
I changed validation for new layout name to fix the bug.
image

Fixed Issues (if relevant)

  1. Fixes New layout action doesn't accept valid layout names #1094

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@SilinMykola SilinMykola force-pushed the 1094-fix-new-layout-action branch 6 times, most recently from 851c8c5 to 7da2e08 Compare June 14, 2022 12:56
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @SilinMykola !

Thank you!

@bohdan-harniuk bohdan-harniuk merged commit 8486929 into magento:4.4.0-develop Jun 15, 2022
@SilinMykola SilinMykola deleted the 1094-fix-new-layout-action branch June 16, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New layout action doesn't accept valid layout names
2 participants