Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1051 fix already disposed exception #1081

Merged
merged 3 commits into from
Apr 18, 2022
Merged

1051 fix already disposed exception #1081

merged 3 commits into from
Apr 18, 2022

Conversation

Iamwade
Copy link
Collaborator

@Iamwade Iamwade commented Apr 18, 2022

Fixed Issues (if relevant)

  1. Fixes [Bug] com.intellij.serviceContainer.AlreadyDisposedException: Cannot create com.intellij.openapi.project.DumbService because container is already disposed in MagentoComponentManager.getComponents #1051

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Iamwade Iamwade requested a review from bohdan-harniuk April 18, 2022 11:14
@Iamwade Iamwade self-assigned this Apr 18, 2022
@bohdan-harniuk bohdan-harniuk self-assigned this Apr 18, 2022
bohdan-harniuk
bohdan-harniuk approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Iamwade!

Thank you for your work here!

@bohdan-harniuk bohdan-harniuk merged commit de9b5db into magento:4.3.1-develop Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohdan-harniuk bohdan-harniuk

Assignees

@bohdan-harniuk bohdan-harniuk

@Iamwade Iamwade

Labels
Easy Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iamwade @bohdan-harniuk