Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for overrite for js and css files in theme #1046

Merged

Conversation

SilinMykola
Copy link
Contributor

Description (*)
Hi all! I checked overwriting javascript and styles files and made some changes.

  1. Overwriting a template from a module:
    image
    image
    image
  2. Overwriting a template from a heme to another theme:
    image
    image
    image
  3. Overwriting a js from module to a theme:
    image
    image
    image
  4. Overwriting a js file from a theme to another theme:
    image
  5. Overwriting a js file from lib/web folder:
    image
    image
    image
  6. Overwriting a lib js files from one theme to another works to.
  7. Overwriting styles for less and css files:
    image
    image
    image
  8. From one theme to another:
    image

Fixed Issues (if relevant)

  1. Fixes Not possible to override the js/css files from the lib/web/* folder #603
  2. Fixes Template Override dialog provides incompatible options #602

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Sorry, something went wrong.

@SilinMykola
Copy link
Contributor Author

@magento run all tests

Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @SilinMykola!

Thank you for your work here! It is great!

Regards,

@bohdan-harniuk bohdan-harniuk merged commit 4d54cb7 into magento:4.3.0-develop Mar 25, 2022
@SilinMykola SilinMykola deleted the 603-fix-js-css-rewrite branch March 27, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants