Skip to content

1023: [UCT] Added theme scanning #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
8897c15
828: rename inspection titles
doninAtwix Feb 22, 2022
ac1a97c
828: update code style
doninAtwix Feb 22, 2022
ab81ce1
414: Added Images support for Copy Magento Path
doninAtwix Feb 28, 2022
11dbae8
409: Added arguments injection/replacement action
bohdan-harniuk Mar 7, 2022
1ea194e
409: Code refactoring
bohdan-harniuk Mar 7, 2022
238dd49
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Mar 7, 2022
e06a65b
Merge pull request #1020 from doninAtwix/414-add-action-copy-path-image
bohdan-harniuk Mar 7, 2022
d93801f
966 add context action to create layout xml file
Feb 28, 2022
79bcc60
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Mar 7, 2022
2cf2f80
967: Code refactoring
bohdan-harniuk Mar 7, 2022
134472d
967: Code refactoring
bohdan-harniuk Mar 7, 2022
42ca0e0
967: Code refactoring
bohdan-harniuk Mar 7, 2022
5d661e6
409: Added argument injection/replacement test cases
bohdan-harniuk Mar 9, 2022
aeffd6f
409: Suppressed warning
bohdan-harniuk Mar 9, 2022
f8901e2
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Mar 9, 2022
3293ea1
409: Added target type suggestion
bohdan-harniuk Mar 9, 2022
2dd6eac
Merge pull request #1027 from bohdan-harniuk/409-add-argument-replace…
Iamwade Mar 10, 2022
2a0ec5f
967 fixes after CR
Mar 10, 2022
66394a6
967: Code refactoring after code review
bohdan-harniuk Mar 10, 2022
83fc536
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Mar 10, 2022
875b63d
Merge pull request #1021 from SilinMykola/967-add-context-action-to-c…
bohdan-harniuk Mar 11, 2022
103b417
828: Code refactoring
bohdan-harniuk Mar 11, 2022
441031d
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Mar 11, 2022
b1dbfbe
Merge pull request #1015 from doninAtwix/828-rename-inspection-titles
bohdan-harniuk Mar 14, 2022
9e799ac
1023: added functional for addtional scanning files
doninAtwix Mar 14, 2022
667f86b
1023: Removed unnecessary files
bohdan-harniuk Mar 14, 2022
6228b90
1023: Added support of the theme component
bohdan-harniuk Mar 15, 2022
6f24218
1023: Added phtml files support
bohdan-harniuk Mar 15, 2022
d1db080
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
bohdan-harniuk Mar 15, 2022
47d4cdc
1023: Added themes count into the json report
bohdan-harniuk Mar 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
409: Added argument injection/replacement test cases
  • Loading branch information
bohdan-harniuk committed Mar 9, 2022
commit 5d661e6062434aa4c64fb6ef8e0fc09494665220
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="methods" xsi:type="array">
<item name="method1" xsi:type="string">QW1</item>
<item name="method2" xsi:type="string">QW2</item>
<item name="method3" xsi:type="string">QW3</item>
<item name="method4" xsi:type="string">QW4</item>
<item name="method5" xsi:type="string">QW5</item>
</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="isEmpty" xsi:type="boolean">false</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="defaultService" xsi:type="const">Foo\Bar\Model\ServiceTest::DEFAULT_SERVICE</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="defaultArea" xsi:type="init_parameter">Foo\Bar\Model\AreaTest::DEFAULT_AREA</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="methods" xsi:type="array">
<item name="method1" xsi:type="string">QW1</item>
<item name="method2" xsi:type="string">QW2</item>
<item name="method3" xsi:type="string">QW3</item>
<item name="method4" xsi:type="string">QW4</item>
<item name="nested" xsi:type="array">
<item name="nested1" xsi:type="string">NT1</item>
<item name="nested2" xsi:type="boolean">true</item>
<item name="nested3" xsi:type="null"/>
</item>
</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="object" xsi:type="null"/>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="age" xsi:type="number">12</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="object" xsi:type="object">Foo\Bar\Model\Service</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="name" xsi:type="string">test</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="anotherArgument1" xsi:type="number">1111</argument>
<argument name="object" xsi:type="object">Foo\Bar\Model\ServiceFactory</argument>
<argument name="anotherArgument2" xsi:type="string">Just another argument</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="anotherArgument1" xsi:type="number">1111</argument>
<argument name="object" xsi:type="null"/>
<argument name="anotherArgument2" xsi:type="string">Just another argument</argument>
</arguments>
</type>
</config>
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="anotherArgument1" xsi:type="number">1111</argument>
<argument name="object" xsi:type="object">Foo\Bar\Model\Service\Proxy</argument>
<argument name="anotherArgument2" xsi:type="string">Just another argument</argument>
</arguments>
</type>
</config>
11 changes: 11 additions & 0 deletions testData/project/magento2/app/code/Foo/Bar/etc/crontab/di.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Foo\Bar\Model\Test">
<arguments>
<argument name="anotherArgument1" xsi:type="number">1111</argument>
<argument name="object" xsi:type="object">Foo\Bar\Model\Service</argument>
<argument name="anotherArgument2" xsi:type="string">Just another argument</argument>
</arguments>
</type>
</config>
Loading