Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1012: Updating generating UI form Delete button #1019

Merged

Conversation

doninAtwix
Copy link
Contributor

Description (*)

Updated generating of the "UI form Delete" button.

The sorting for buttons has been changed:

  • Back button: 10
  • Delete button: 20
  • Save button: 30

Also, for the Delete button, the on click option changed to use the sprintf function instead of the concatenation.

Screenshot 2022-02-23 at 15 28 45

Fixed Issues (if relevant)

  1. Fixes Simplify/Unify the syntax of generated buttons for UI Form #1012

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@Iamwade Iamwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bohdan-harniuk @doninAtwix Looks good to me!
Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify/Unify the syntax of generated buttons for UI Form
2 participants