[CMS Team 2 - Sprint 11] Tech Debt and Empty Banner Bug #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the xsd for conent types
- Updated the group xsd to move label to a named attribute
- update content type configs
- update groups config
- change additional_date items to item
- update documentation
- Updated the xsd to support new configurations - Updated converter, reader, and parser to support the new attributes
- Updated frontend composite reader
- Added converter and previe converters to set display none on condition - Updated banner appearances to use the display converters
…e-configuration-nodes-to-attributes
- Updated content_type.xsd to only have name to be required field
- update content types and groups integration tests
- Updated content_type.xsd required attributes - Updated converter naming convention and documentation
- Updated converters to use new form vlaues - Added test coverage for the bug
- Removed typo and extra line
- Fixed return typing on display converters
- Remove extra spaces in display converter - Moved empty banner test into the 4 appearances - Fixed broken tests that were the result of change - Fixed buttonItem test failure
- Resolved unrelated test failure on button link
- Split up content type specific converters for margins and padding - Updated configuration for all components to stop using composite converters and readers - Delete composite converters and readers - Update documentation
- Split margins-and-padding missed usage in slide configuration
- Removed buttonItemData fix
- Removed buttonItemData fix
- Updated tests to remove tabbing functions and unique title and descriptions
- Fix formatting issue is docs
- fix formatting of type attributes
- fix formatting for appearance attributes
…n-nodes-to-attributes' into cms-team-2-sprint-11
… into cms-team-2-sprint-11
…y-area' into cms-team-2-sprint-11
- remove unused files
Contributor
|
Re-ran Functional EE since test failures looked like the Google Maps API service was down. Will continue to monitor these tests, and determine if they can continue being automated without occasional service disruptions like this. https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/749/ |
magento-cicd2
pushed a commit
that referenced
this pull request
Jun 29, 2021
AC-233: Refactor core MFTF TinyMCE ActionGroup
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 30, 2024
Merge develop branch into AC-12726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Story
Bug
Bamboo CI Builds
Jenkins
Checklist