Skip to content

[Owls] Video background for Slide #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
4231ab7
PB-266: Video background for Slide
eug123 Feb 11, 2020
4355811
PB-265: Video background for Banner
cspruiell Feb 13, 2020
b84757d
PB-266: Video background for Slide
eug123 Feb 13, 2020
1521cca
PB-266: Video background for Slide
eug123 Feb 13, 2020
b368135
Merge remote-tracking branch 'mainline/develop' into PB-266-with-row
eug123 Feb 18, 2020
99b7701
PB-266: Video background for Slide
eug123 Feb 18, 2020
0c4bae0
PB-266: Video background for Slide
eug123 Feb 18, 2020
62a9a46
Merge remote-tracking branch 'origin/develop' into PB-265-video-backg…
cspruiell Feb 18, 2020
46f9d26
PB-370: Introduce upgrade mechanism for Page Builder content
cspruiell Feb 18, 2020
c6a89da
PB-266: Video background for Slide
eug123 Feb 19, 2020
89d3e3f
PB-266: Video background for Slide
eug123 Feb 19, 2020
1bb8617
PB-266: Video background for Slide
eug123 Feb 19, 2020
75a8b38
PB-265: Video background for Banner
cspruiell Feb 19, 2020
50ad98c
PB-265: Video background for Banner
cspruiell Feb 19, 2020
bfcbf42
Merge remote-tracking branch 'origin/develop' into PB-265-video-backg…
cspruiell Feb 19, 2020
180471f
PB-266: Video background for Slide
eug123 Feb 19, 2020
1f1a258
Merge remote-tracking branch 'origin/develop' into PB-265-video-backg…
cspruiell Feb 20, 2020
50861fb
PB-266: Video background for Slide
eug123 Feb 20, 2020
c70a4a4
PB-265: Video background for Banner
cspruiell Feb 20, 2020
ca7ca38
PB-265: Video background for Banner
cspruiell Feb 20, 2020
3223f3b
PB-370: Introduce upgrade mechanism for Page Builder content
cspruiell Feb 20, 2020
f77f769
PB-266: Video background for Slide
eug123 Feb 24, 2020
b586c7a
PB-266: Video background for Slide
eug123 Feb 24, 2020
93c515e
PB-266: Video background for Slide
eug123 Feb 25, 2020
33513e5
Merge remote-tracking branch 'mainline/develop' into PB-266-with-row
eug123 Feb 25, 2020
1d338fd
PB-266: Video background for Slide
eug123 Feb 25, 2020
011c9e5
Merge remote-tracking branch 'origin/develop' into PB-265-video-backg…
cspruiell Feb 25, 2020
51a426e
PB-265: Video background for Banner
cspruiell Feb 25, 2020
f047afc
PB-265: Video background for Banner
omiroshnichenko Feb 25, 2020
f331b38
PB-265: Video background for Banner
omiroshnichenko Feb 25, 2020
718c6c4
Merge branch 'develop' into PB-265-video-background-for-banner
omiroshnichenko Feb 25, 2020
40359e9
PB-265: Video background for Banner
omiroshnichenko Feb 25, 2020
ca9d308
Merge branch 'PB-265-video-background-for-banner' of github.com:magen…
omiroshnichenko Feb 25, 2020
842e0e1
PB-266: Video background for Slide
eug123 Feb 25, 2020
d68faef
PB-266: Video background for Slide
eug123 Feb 25, 2020
5af0fd7
PB-266: Video background for Slide
eug123 Feb 26, 2020
d0d50e1
PB-265: Video background for Banner
omiroshnichenko Feb 26, 2020
b1db099
PB-266: Video background for Slide
eug123 Feb 26, 2020
fa9a098
PB-266: Video background for Slide
eug123 Feb 26, 2020
7045419
PB-266: Video background for Slide
eug123 Feb 26, 2020
d3cf705
Merge remote-tracking branch 'origin/PB-265-video-background-for-bann…
eug123 Feb 26, 2020
04b8bd2
Merge remote-tracking branch 'mainline/develop' into PB-266-with-row
eug123 Feb 26, 2020
45b8f8a
PB-266: Video background for Slide
eug123 Feb 26, 2020
7ed82b8
PB-266: Video background for Slide
eug123 Feb 26, 2020
009f944
PB-266: Video background for Slide
eug123 Feb 27, 2020
944f6da
PB-266: Video background for Slide
dhaecker Feb 27, 2020
d6efc89
PB-265: Video background for Banner
omiroshnichenko Feb 27, 2020
3998387
PB-266: Video background for Slide
eug123 Feb 27, 2020
c9f4f59
PB-266: Video background for Slide
omiroshnichenko Feb 28, 2020
57df0cb
Merge branch 'develop' into PB-265-video-background-for-banner
omiroshnichenko Feb 28, 2020
bfca6a3
PB-266: Video background for Slide
dhaecker Feb 28, 2020
b500c9f
Merge branch 'PB-266-with-row' of github.com:magento-obsessive-owls/m…
dhaecker Feb 28, 2020
e2c30c6
PB-265: Video background for Banner
omiroshnichenko Feb 28, 2020
8739a69
PB-265: Video background for Banner
omiroshnichenko Feb 28, 2020
ad7a553
PB-265: Video background for Banner
omiroshnichenko Feb 28, 2020
068acfd
PB-266: Video background for Slide
eug123 Feb 28, 2020
787cacd
Merge branch 'develop' into PB-265-video-background-for-banner
omiroshnichenko Feb 29, 2020
6409969
PB-266: Video background for Slide
dhaecker Feb 29, 2020
0a2e0ad
PB-266: Video background for Slide
dhaecker Mar 1, 2020
1af3f58
PB-266: Video background for Slide
dhaecker Mar 1, 2020
61bac05
PB-266: Video background for Slide
omiroshnichenko Mar 1, 2020
a4195f2
Merge branch 'PB-265-video-background-for-banner' of github.com:magen…
omiroshnichenko Mar 1, 2020
cf80778
PB-266: Video background for Slide
omiroshnichenko Mar 1, 2020
2b3a5b3
PB-266: Video background for Slide
dhaecker Mar 1, 2020
f732f64
Merge branch 'PB-266-with-row' of github.com:magento-obsessive-owls/m…
dhaecker Mar 1, 2020
3ff476c
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
82557e6
Merge branch 'PB-265-video-background-for-banner' of github.com:magen…
omiroshnichenko Mar 2, 2020
d18ffeb
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
3ba7fe8
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
610851f
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
319f844
PB-266: Video background for Slide
omiroshnichenko Mar 2, 2020
2ab25d1
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
c1ccc45
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
fc11bfb
Merge branch 'develop' into PB-266-with-row
omiroshnichenko Mar 2, 2020
6b96be2
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
6cd9f5a
PB-265: Video background for Banner
omiroshnichenko Mar 2, 2020
93fad4f
PB-266: Video background for Slide
eug123 Mar 2, 2020
0baaf06
PB-266: Video background for Slide
eug123 Mar 3, 2020
0b5ec34
PB-265: Video background for Banner
omiroshnichenko Mar 3, 2020
f4788fc
Merge branch 'PB-266-with-row' of github.com:magento-obsessive-owls/m…
omiroshnichenko Mar 3, 2020
b1b4002
PB-265: Video background for Banner
omiroshnichenko Mar 3, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PB-265: Video background for Banner
 - update tests
  • Loading branch information
cspruiell committed Feb 25, 2020
commit 51a426e1331c51cd4cb556cb4855065772ec664e
Original file line number Diff line number Diff line change
Expand Up @@ -1467,4 +1467,33 @@
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
</actionGroup>
</test>
<test name="BannerCollageCenterMinHeightValidInputs" extends="BannerPosterMinHeightValidInputs">
<annotations>
<features value="PageBuilder"/>
<stories value="Banner"/>
<title value="Collage Center - Banner Min Height Valid Inputs"/>
<description value="A user can submit valid min height values (px, view port percentages, calculations, etc.) and they apply correctly to a collage center banner."/>
<severity value="BLOCKER"/>
<useCaseId value="PB-378"/>
<testCaseId value="MC-31599"/>
<group value="pagebuilder"/>
<group value="pagebuilder-banner"/>
<group value="pagebuilder-bannerCollageCenter"/>
</annotations>
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
</actionGroup>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('1', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeFirstMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('1')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStage"/>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('2', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeSecondMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('2')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="secondMinHeightStage"/>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeThirdMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('3')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="thirdMinHeightStage"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('1', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeFirstMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('1')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStorefront"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('2', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeSecondMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('2')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="secondMinHeightStorefront"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeThirdMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('3')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="thirdMinHeightStorefront"/>
</test>
</tests>
Original file line number Diff line number Diff line change
Expand Up @@ -1470,4 +1470,33 @@
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
</actionGroup>
</test>
<test name="BannerCollageLeftMinHeightValidInputs" extends="BannerPosterMinHeightValidInputs">
<annotations>
<features value="PageBuilder"/>
<stories value="Banner"/>
<title value="Collage Left - Banner Min Height Valid Inputs"/>
<description value="A user can submit valid min height values (px, view port percentages, calculations, etc.) and they apply correctly to a collage left banner."/>
<severity value="BLOCKER"/>
<useCaseId value="PB-378"/>
<testCaseId value="MC-31598"/>
<group value="pagebuilder"/>
<group value="pagebuilder-banner"/>
<group value="pagebuilder-bannerCollageLeft"/>
</annotations>
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
</actionGroup>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('1', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeFirstMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('1')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStage"/>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('2', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeSecondMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('2')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="secondMinHeightStage"/>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeThirdMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('3')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="thirdMinHeightStage"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('1', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeFirstMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('1')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStorefront"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('2', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeSecondMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('2')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="secondMinHeightStorefront"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeThirdMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('3')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="thirdMinHeightStorefront"/>
</test>
</tests>
Original file line number Diff line number Diff line change
Expand Up @@ -1371,4 +1371,33 @@
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
</actionGroup>
</test>
<test name="BannerCollageRightMinHeightValidInputs" extends="BannerPosterMinHeightValidInputs">
<annotations>
<features value="PageBuilder"/>
<stories value="Banner"/>
<title value="Collage Right - Banner Min Height Valid Inputs"/>
<description value="A user can submit valid min height values (px, view port percentages, calculations, etc.) and they apply correctly to a collage right banner."/>
<severity value="BLOCKER"/>
<useCaseId value="PB-378"/>
<testCaseId value="MC-31600"/>
<group value="pagebuilder"/>
<group value="pagebuilder-banner"/>
<group value="pagebuilder-bannerCollageRight"/>
</annotations>
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
</actionGroup>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('1', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeFirstMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('1')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStage"/>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('2', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeSecondMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('2')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="secondMinHeightStage"/>
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeThirdMinHeightStage"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnBackend.wrapper('3')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="thirdMinHeightStage"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('1', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeFirstMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('1')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStorefront"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('2', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeSecondMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('2')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="secondMinHeightStorefront"/>
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeThirdMinHeightStorefront"/>
<executeJS function="return document.evaluate(&quot;{{BannerOnFrontend.wrapper('3')}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="thirdMinHeightStorefront"/>
</test>
</tests>
Original file line number Diff line number Diff line change
Expand Up @@ -3388,7 +3388,7 @@
<argument name="contentTypeIndex" value="1"/>
</actionGroup>
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
<argument name="property" value="PageBuilderAppearance_Poster"/>
</actionGroup>
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty1">
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
Expand Down
Loading