Skip to content

Conversation

@cspruiell
Copy link
Contributor

@cspruiell cspruiell commented Feb 1, 2019

anthoula and others added 30 commits January 10, 2019 15:55
- set column to grow to maximum available height instead of inheriting height
- update existing test to check expected column height
- add max-width to column children to enable text wrapping and preventing children overflowing
- set min-height to column children to support 200px min-height config
- update existing tests to exclude padding from expected column height
- update existing tests to exclude padding from expected column height
- Move all data migration related code into seperate Magento module “Magento_PageBuilderDataMigration”
- make default column height same as row
- remove row margins preview converter from row to resolve 1px height difference
- remove extra height to content types to ensure row does not resize when dropped into row
- fix tab item top border after removing the transparent border from system-border
- fix existing tests to account for new min height for column
- revert removing 1px transparent border on content types due to incompatibility with selenium doNotSeeElement
- revert Tab border top fixes
- Resolve static failures
- Resolve CR comments
…or iPhone on Storefront

- turn off background-attachment fixed in mobile due to partial device support
- add test coverage for existing test
…or iPhone on Storefront

- fix parallax zero setting to background image fixed admin and storefront
- Fix introduction of string type within converter
…or iPhone on Storefront

- fix static js errors
…uct (Description, Short Description, Attribute)

 - Adding smoke tests for pagebuilder in catalog products
 - Deleting unused actiongroups
 - Adding/updating supporting actiongroups, data, sections
…05-column-height

# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/column.xml
…dmin

- fix banner and slider tinymce menu styles to match
- Added inner element to full bleed appearance configuration
- Added test coverage for this issue
- Added expand panel group step to RowFullBleedAppearanceNoErrorThrown test
…uct (Description, Short Description, Attribute)

 - Adding mftf test PageBuilderWorksForEachProductAttribute
 - Adding/updating supporting actiongroups, data, sections
anthoula and others added 27 commits January 29, 2019 15:42
…s/magento2-page-builder into MC-3328-mftf-block
 - Updating tests to use actionGroups & createData
- add CMS Block tests for disabled pagebuilder
MAGEDOC-3483: Fix Quote content type
Included more examples showing how icons and images are used within forms and on the stage.
Accepting PR suggestion

Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting PR suggestion

Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting PR suggestion

Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting PR suggestion

Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting suggested change

Co-Authored-By: bdenham <bdenham@adobe.com>
Accepted suggested change

Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting suggested change

Co-Authored-By: bdenham <bdenham@adobe.com>
MAGEDOC-3424: Update Iconography topic
@cspruiell cspruiell merged commit 34891c0 into magento:1.0.0-release Feb 4, 2019
@davemacaulay davemacaulay deleted the sync-1.0.0-release-with-beta branch August 5, 2019 15:17
magento-devops-reposync-svc pushed a commit that referenced this pull request Mar 14, 2023
AC-7850: [2.4.6-develop] Build Failures with PHP 8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants