-
Notifications
You must be signed in to change notification settings - Fork 73
Sync 1.0.0 release with beta #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cspruiell
merged 76 commits into
magento:1.0.0-release
from
magento-obsessive-owls:sync-1.0.0-release-with-beta
Feb 4, 2019
Merged
Sync 1.0.0 release with beta #206
cspruiell
merged 76 commits into
magento:1.0.0-release
from
magento-obsessive-owls:sync-1.0.0-release-with-beta
Feb 4, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set column to grow to maximum available height instead of inheriting height - update existing test to check expected column height
- add max-width to column children to enable text wrapping and preventing children overflowing - set min-height to column children to support 200px min-height config
- update existing tests to exclude padding from expected column height
- update existing tests to exclude padding from expected column height
- Move all data migration related code into seperate Magento module “Magento_PageBuilderDataMigration”
- make default column height same as row - remove row margins preview converter from row to resolve 1px height difference
- remove extra height to content types to ensure row does not resize when dropped into row
- fix tab item top border after removing the transparent border from system-border
- fix existing tests to account for new min height for column
- revert removing 1px transparent border on content types due to incompatibility with selenium doNotSeeElement - revert Tab border top fixes
- Resolve static failures - Resolve CR comments
- Fix static failures
…or iPhone on Storefront - turn off background-attachment fixed in mobile due to partial device support - add test coverage for existing test
…or iPhone on Storefront - fix parallax zero setting to background image fixed admin and storefront
- Fix introduction of string type within converter
- Resolve issue with integration tests
…or iPhone on Storefront - fix static js errors
- Fix integration test
…uct (Description, Short Description, Attribute) - Adding smoke tests for pagebuilder in catalog products - Deleting unused actiongroups - Adding/updating supporting actiongroups, data, sections
…05-column-height # Conflicts: # app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/column.xml
…dmin - fix banner and slider tinymce menu styles to match
- Added inner element to full bleed appearance configuration - Added test coverage for this issue
- Added expand panel group step to RowFullBleedAppearanceNoErrorThrown test
…uct (Description, Short Description, Attribute) - Adding mftf test PageBuilderWorksForEachProductAttribute - Adding/updating supporting actiongroups, data, sections
…s/magento2-page-builder into MC-3328-mftf-block
- move and namespace tests to CMS Block
- Add CMS Block move slide and tab items
- add CMS Block tests for full screen
- Updating tests to use actionGroups & createData
- add CMS Block tests for disabled pagebuilder
MAGEDOC-3483: Fix Quote content type
Included more examples showing how icons and images are used within forms and on the stage.
Accepting PR suggestion Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting PR suggestion Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting PR suggestion Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting PR suggestion Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting suggested change Co-Authored-By: bdenham <bdenham@adobe.com>
Accepted suggested change Co-Authored-By: bdenham <bdenham@adobe.com>
Accepting suggested change Co-Authored-By: bdenham <bdenham@adobe.com>
Updated from PR review
One more from PR review
MAGEDOC-3424: Update Iconography topic
[Owls] Docs for beta 5 release
[Owls] Beta Release 6
…1.0.0-release-with-beta
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 14, 2023
AC-7850: [2.4.6-develop] Build Failures with PHP 8.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins: https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/13259/
PB EE PR: https://github.com/magento/magento2-page-builder-ee/pull/42