[CMS Team 1] Background Attributes, Hide Content #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add Layout section to Edit Tab form - move min height field to Layout section - add vertical alignment field
- add justify content property to tab item xml - add container element with vertical alignment styles to tab item xml
- update preview and master template with container styles
- update master format to include tab vertical alignment styles
- update min height section in Edit Tab form
- Add new concealable attribute to content type configuration - Refactor getOptions to only call retrieveOptions once - Modify ContentTypeMenu to always use addOption when populating the options in a menu - Implement new bindEvents method on option for event initiation
- Implement reading & writing to master format for all content types which don’t currently use display style property - Add show / hide icons
- add test for layout configuration default validation
- add test for layout configuration default validation
- standardize container element name to match preview
- move test to layout test file
- Show hidden state in admin
- fix selectors to target -nth element
- rename action group - fix index - add work-around for mftf hyphen bug
- add test for vertical alignment with no heights
- Enable hiding content blocks in all containers and ensure experience is unified between types - Ensure active tab doesn’t lay over the hidden overlay - Ensure slider hover state doesn’t overlay self on top of disabled state
- Add support for button and button items - Add faint text shadow to icon
- reorder Edit Tab form sections
- remove reference to row in action group
- update group and testCaseID values
- add selectors for layout action group
- add test for vertical alignment with various min heights
- add test for min height validation
- update severity flag - update titles - move expand group before dragging content type - add comments - resolve storefront nav issue
- remove stray group - add selector for no min height - add semicolons
- Fix issues with buttons when hidden
…Background-Attributes-for-Tab
…cal-align # Conflicts: # app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/LayoutConfigurationActionGroup.xml # app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTabsSection.xml
- stabilize tests
- Fix commenting on action group
- Resolve CR comments in tests
# Conflicts: # dev/tests/static/testsuite/Magento/Test/Integrity/Xml/ExtendsBaseFormTest.php
- Resolve issues with merge
- Resolve issue with targeting text on second tab due to background images
…cms-team-1-delivery # Conflicts: # app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTabsSection.xml # app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_tab_item_form.xml # app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/tab-item/default/master.html # app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/tab-item/default/preview.html # app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/tab_item.xml
- fix selectors after merge
- fix tab item config after merge
- fix hiding for items inside tab - fix vertical alignment on storefront
# Conflicts: # app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTabsSection.xml # app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml # app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemConfigurationTests.xml # app/code/Magento/PageBuilder/docs/content-type-configuration.md # app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slider/_default.less # app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/tabs/_default.less # app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview.js # app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/tab-item/default/preview.html # app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/preview.ts
- fix merge issues
- fix merge issues
- fix merge issues & stabilize tests
- fix merge issues & stabilize tests
- stop overlay toggle for hidden blocks
# Conflicts: # app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml
- ensure focused tab is set on load
- fix static failures
- stabilize tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Stories
MC-913: Explicit Background Attributes for Tab
MC-969: Explicit Background Attributes for Slide
MC-965: Hide Content block/ container from the stage
MC-931: Content Vertical Alignment inside a Container for Tab Item
Bugs
MC-829 Empty slide displays on store front as big empty area
Builds
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/3603/
Checklist