Skip to content

MQE-2242: Add static check to flag use of <pause> #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2020
Merged

MQE-2242: Add static check to flag use of <pause> #783

merged 2 commits into from
Aug 14, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Aug 12, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau soumyau force-pushed the MQE-2242 branch 2 times, most recently from 4f548b1 to 0434364 Compare August 13, 2020 00:00
@coveralls
Copy link

coveralls commented Aug 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 61.332% when pulling e4f7d92 on MQE-2242 into 85d4fa6 on develop.

jilu1
jilu1 reviewed Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Have minor question and comment, please check

@soumyau soumyau merged commit ba3362b into develop Aug 14, 2020
@tomreece tomreece deleted the MQE-2242 branch August 19, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @jilu1