-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-2110: MFTF command to pause test execution #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Magento/FunctionalTestingFramework/Console/RunManifestCommand.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Test/Util/TestHookObjectExtractor.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added notes on observations during test runs.
# Conflicts: # dev/tests/unit/Magento/FunctionalTestFramework/Test/Handlers/TestObjectHandlerTest.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall implementation looks solid, try kicking off a UR build as well + documentation.
src/Magento/FunctionalTestingFramework/Console/BaseGenerateCommand.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Console/RunManifestCommand.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Console/RunTestFailedCommand.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Test/Util/TestHookObjectExtractor.php
Show resolved
Hide resolved
@dobooth This PR has document change. Can you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a verification/unit test for codecept:run? Also re-run build
src/Magento/FunctionalTestingFramework/Console/BaseGenerateCommand.php
Outdated
Show resolved
Hide resolved
docs/interactive-pause.md
Outdated
Here is a typical work flow for this use case: | ||
|
||
- Set `ENABLE_PAUSE` to `true` under `.env` | ||
- Add `<pause>` action in a test where you want to stop for investigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add <pause>
action in a test where you want to pause execution for debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced
docs/interactive-pause.md
Outdated
|
||
You can also use MFTF's wrapper command to run Codeception directly and activate `Interactive Pause` by passing `--debug` option. | ||
You do not need to set `ENABLE_PAUSE=true` for this command. | ||
You do not need to set `ENABLE_PAUSE=true` for this command if you are not using `Pause on Failure`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need to set ENABLE_PAUSE=true
for this command if you don't want to pause on test failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced
Description
Fixed Issues (if relevant)
Contribution checklist