Skip to content

MQE-2110: MFTF command to pause test execution #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 15, 2020
Merged

MQE-2110: MFTF command to pause test execution #781

merged 14 commits into from
Aug 15, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Aug 7, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Aug 7, 2020

Coverage Status

Coverage decreased (-0.004%) to 61.328% when pulling e6122a8 on MQE-2110 into ba3362b on develop.

Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added notes on observations during test runs.

jilu1 added 2 commits August 13, 2020 09:34
# Conflicts:
#	dev/tests/unit/Magento/FunctionalTestFramework/Test/Handlers/TestObjectHandlerTest.php
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall implementation looks solid, try kicking off a UR build as well + documentation.

@jilu1
Copy link
Contributor Author

jilu1 commented Aug 14, 2020

@dobooth This PR has document change. Can you please review it?

dobooth
dobooth previously approved these changes Aug 14, 2020
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a verification/unit test for codecept:run? Also re-run build

Here is a typical work flow for this use case:

- Set `ENABLE_PAUSE` to `true` under `.env`
- Add `<pause>` action in a test where you want to stop for investigation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <pause> action in a test where you want to pause execution for debugging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced


You can also use MFTF's wrapper command to run Codeception directly and activate `Interactive Pause` by passing `--debug` option.
You do not need to set `ENABLE_PAUSE=true` for this command.
You do not need to set `ENABLE_PAUSE=true` for this command if you are not using `Pause on Failure`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to set ENABLE_PAUSE=true for this command if you don't want to pause on test failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced

@jilu1 jilu1 merged commit a843666 into develop Aug 15, 2020
@dobooth dobooth added the DOC label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants