-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-1886: Ability to use grab data between ActionGroups #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple case works as expected. I would suggest to discuss with team to clearly define cases like:
- should we allow
return
be used in any where in an action group? - what's the expected behaviors when action groups with returns get merged? Currently it results an error
- what's the expected behaviors when action groups with returns get extends? Currently it's results is not ideal and sometimes an error
- Make sure to check the
return
in before/after case, it seems not working for me - Have we talked about returning more than one values in an array?
src/Magento/FunctionalTestingFramework/Test/etc/Actions/customActions.xsd
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Test/etc/mergedActionGroupSchema.xsd
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please add verification tests for merge, extends, return values in before/after, etc
added verification steps
verification tests + other fixes
added functional test.
|
|
...sts/verification/TestModule/Test/ActionGroupFunctionalTest/ActionGroupReturningValueTest.xml
Show resolved
Hide resolved
Do you mean currently we can return multiple values? This is documented in action-groups.md Above issues, some of the issues are caused by existing bug (merge) or existing limitations (in before/after). Can we document the expect behavior for them? e.g. |
added functional test. Removed functional test for return.
Description
Fixed Issues (if relevant)
Contribution checklist