MQE-2162: Chrome remains running after MFTF suite finishes #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify |
KevinBKozan
suggested changes
Jun 8, 2020
| @@ -84,6 +88,9 @@ class {{suiteName}} extends \Codeception\GroupObject | |||
| if ($this->currentTestRun == $this->testCount) { | |||
| print sprintf(self::$HOOK_EXECUTION_INIT, "after"); | |||
|
|
|||
| /** @var MagentoWebDriver $webDriver */ | |||
| $webDriver = $this->getModule('\Magento\FunctionalTestingFramework\Module\MagentoWebDriver'); | |||
There was a problem hiding this comment.
I'd rather we use MagentoWebDriver::class if possible (here and all other places in this PR).
| $webDriverConfig = $webDriver->_getConfig(); | ||
| $webDriver->_closeSession(); | ||
| if (isset($webDriverConfig['close_all_sessions']) && $webDriverConfig['close_all_sessions'] === "true") { | ||
| $wdHost = sprintf( |
There was a problem hiding this comment.
I see a protected function stopAllSessions() in WebDriver.php, which MagentoWebDriver extends. It seems to do similarly what we do here, did you try and make it work?
KevinBKozan
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jenkins Build
Contribution checklist