Skip to content

MQE-830: Output error details about test failure #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2018
Merged

MQE-830: Output error details about test failure #73

merged 5 commits into from
Mar 28, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Added new extension to allow for pulling and operation on testContext at test runtime
  • Tests now no longer allow for exceptions in _after block to overwrite the original exception (case when test fails, runs _after and fails there too)
  • Tests no longer run the _after block if the test failure was in the _after block to begin with.

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<830>: Output error details about test failure

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-830: Output error details about test failure
471aaaf 
- Introduces TestContextExtension, used to keep track of where in the test we are.
- Changed generator to use this extension's capabilities, and to not rethrow exceptions in the _failed hook.
- Verification tests will be failing, want to get design reviewed before spending time fixing them.
@KevinBKozan
MQE-830: Output error details about test failure
170af1f 
- Test Fixes, generator fixes
@KevinBKozan
MQE-830: Output error details about test failure
19ba88b 
- refactor to not constantly keep track of state
- test context is now only found when a failure occurs, not set at generator
@KevinBKozan
Merge branch 'develop' into MQE-830
9d1b07a
@KevinBKozan
MQE-830: Output error details about test failure
baae0cb 
- Verification test rollbacks to match output
- static fixes
@coveralls
Copy link

coveralls commented Mar 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 52.982% when pulling baae0cb on MQE-830 into a75d1f4 on develop.

@KevinBKozan KevinBKozan merged commit 6ab66f3 into develop Mar 28, 2018
@KevinBKozan KevinBKozan deleted the MQE-830 branch March 28, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBKozan @coveralls