Skip to content

MQE-2076: [PHPUnit 9] assertEquals and assertNotEquals optional parameters removed #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2020
Merged

MQE-2076: [PHPUnit 9] assertEquals and assertNotEquals optional parameters removed #675

merged 4 commits into from
Apr 21, 2020

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Apr 17, 2020 •
edited
Loading

  • Adds new assert actions for phpunit9
  • Removes delta option from assertEquals and assertNotEquals

Related PRs that need merged with this:

Build

@coveralls
Copy link

coveralls commented Apr 17, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 52.876% when pulling f12f282 on MQE-2076 into 4f1dd85 on MFTF3.0.0-RC2.

@tomreece tomreece changed the base branch from MQE-1704 to MFTF3.0.0-RC2 April 17, 2020 15:09
@tomreece tomreece changed the base branch from MFTF3.0.0-RC2 to MQE-1704 April 17, 2020 15:10
@tomreece tomreece changed the base branch from MQE-1704 to MFTF3.0.0-RC2 April 17, 2020 16:06
@tomreece tomreece requested a review from dobooth April 17, 2020 16:22
@tomreece tomreece merged commit bbab15d into MFTF3.0.0-RC2 Apr 21, 2020
@tomreece tomreece deleted the MQE-2076 branch April 30, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobooth dobooth dobooth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @dobooth