MQE-2078: [PHPUnit 9] assertContains and assertNotContains breaking c…

[soumyau]

…hanges

added new actions
assertStringContainsString
assertStringContainsStringIgnoringCase

Description

Fixed Issues (if relevant)

1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
2. ...

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/verification tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)
• Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

[coveralls]

Coverage increased (+0.03%) to 53.19% when pulling b3a2c2b on MQE-2078-2 into a23844b on MQE-1704.

[KevinBKozan]

QAing this, and I have found probable erroneous behavior:

<assertStringContainsString stepKey="1">
    <expectedResult type="string">helloworld</expectedResult>
    <actualResult type="string">hello</actualResult>
</assertStringContainsString>

Based on the above, I feel we should expect MFTF to look for hello in helloworld right? MFTF is generating this backwards:

[soumyau]

QAing this, and I have found probable erroneous behavior:

<assertStringContainsString stepKey="1">
    <expectedResult type="string">helloworld</expectedResult>
    <actualResult type="string">hello</actualResult>
</assertStringContainsString>

Based on the above, I feel we should expect MFTF to look for hello in helloworld right? MFTF is generating this backwards:

Very interesting. So, this is the current behavior on develop as well. I thought we are considerexpectedResult to be the needle and actualResult to be the haystack. In the sense we are checking if expectedResult is a substring of actualResult. Is it the other way around?

[KevinBKozan]

@soumyau I requested @dobooth due to doc updates, otherwise it's good to go