Skip to content

Added exception throwing on test generation if project is not built #61 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vasylmalanka
Copy link
Contributor

Description

Exception throwing has been added to test generation method in order to check if vendor/bin/robo build:project has been ran and .env configuration file has been filled in.

Fixed Issues (if relevant)

  1. Validate build:project was run before attempting to generate tests #61: Validate build:project was run before attempting to generate tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@vasylmalanka vasylmalanka requested a review from okolesnyk March 23, 2018 18:18
@magento-cicd2
Copy link

magento-cicd2 commented Mar 23, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage remained the same at 53.382% when pulling 9763062 on issue-61 into 08c089a on CD-develop.

@okolesnyk
Copy link
Member

@vasylmalanka Please fork magento2-functional-testing-framework and make Pull Request from your fork.

@okolesnyk okolesnyk deleted the issue-61 branch March 24, 2018 11:36
magento-cicd2 pushed a commit that referenced this pull request Jul 2, 2021
…2-functional-testing-framework-841

[Imported] 33307: Eliminated AspectMock usage from GenerationErrorHandlerTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants