Skip to content

MQE-2008: Filter test generation and execution by severity #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 27, 2020
Merged

MQE-2008: Filter test generation and execution by severity #605

merged 9 commits into from
Feb 27, 2020

Conversation

okolesnyk
Copy link
Member

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@okolesnyk okolesnyk requested review from KevinBKozan, jilu1 and soumyau and removed request for KevinBKozan February 25, 2020 22:25
@okolesnyk
Copy link
Member Author

okolesnyk commented Feb 25, 2020 •
edited
Loading

Jenkins build with Magento 2 CE + MSI + PageBuilder + MFTF current branch: https://github.com/magento-pangolin/magento2ce/pull/232

@coveralls
Copy link

coveralls commented Feb 25, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 52.527% when pulling c215ab0 on MQE-2008 into 3426237 on master.

KevinBKozan
KevinBKozan reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find any issues. @jilu1 is still going to QA, but nothing found from my end.

Just had two small comments/concerns

@okolesnyk
Copy link
Member Author

Magento 2 CE + MSI + PageBuilder
Magento 2 EE + MSI + PageBuilder
Magento 2 B2B + MSI + PageBuilder
builds are here magento-pangolin/magento2ce#232

KevinBKozan
KevinBKozan previously requested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment below.

One additional thing is that this new feature could use a new Unit test; check out TestGenerator Unit tests for some inspiration!

jilu1
jilu1 suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA looks good. Unresolved one of my comment. It's a minor issue. Please check.

jilu1
jilu1 previously approved these changes Feb 27, 2020
View reviewed changes
@okolesnyk okolesnyk dismissed KevinBKozan’s stale review February 27, 2020 18:25

We talked about them and I believe we figured it out.

@okolesnyk
MQE-2008: Filter test generation and execution by severity
c215ab0 
- update composer.json and CHANGELOG.md
@okolesnyk okolesnyk merged commit f1d9f9e into master Feb 27, 2020
@KevinBKozan KevinBKozan deleted the MQE-2008 branch April 30, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

@jilu1 jilu1 jilu1 left review comments

@soumyau soumyau Awaiting requested review from soumyau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okolesnyk @coveralls @jilu1 @KevinBKozan