Skip to content

MQE-1988: MFTF failures after PHP upgrade (libzip5 v1.60+) #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2020
Merged

MQE-1988: MFTF failures after PHP upgrade (libzip5 v1.60+) #594

merged 4 commits into from
Feb 11, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Feb 10, 2020

moved facebook/webdriver to replace
added php-webdriver/webdriver

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 52.498% when pulling 67128a1 on MQE-1988 into 55ac3b8 on develop.

@coveralls
Copy link

coveralls commented Feb 10, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 51.047% when pulling 81f826a on MQE-1988 into 6480f03 on 2.6.1-RC.

@soumyau soumyau changed the base branch from develop to 2.6.1-RC February 11, 2020 16:04
@okolesnyk okolesnyk self-requested a review February 11, 2020 17:32
okolesnyk
okolesnyk requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update version under composer.json to be 2.6.1
And update CHANGELOG.md

@soumyau
MQE-1988: MFTF failures after PHP upgrade (libzip5 v1.60+)
f5739a7 
moved facebook/webdriver to replace
added php-webdriver/webdriver
@soumyau
MQE-1988: MFTF failures after PHP upgrade (libzip5 v1.60+)
3497e7d 
moved facebook/webdriver to replace
added php-webdriver/webdriver
@soumyau
MQE-1988: MFTF failures after PHP upgrade (libzip5 v1.60+)
e69feab 
Added Caret Version Range
@soumyau
Copy link
Contributor Author

soumyau commented Feb 11, 2020

moved facebook/webdriver to replace
added php-webdriver/webdriver

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

Please update version under composer.json to be 2.6.1
And update CHANGELOG.md

Done

@okolesnyk okolesnyk added this to the 2.6.1 milestone Feb 11, 2020
@okolesnyk okolesnyk merged commit 4bc7155 into 2.6.1-RC Feb 11, 2020
@soumyau soumyau deleted the MQE-1988 branch April 30, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@soumyau @coveralls @okolesnyk @jilu1