Adding deprecation attribute info #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also add deprecated attr to https://github.com/magento/magento2-functional-testing-framework/blob/develop/docs/metadata.md |
okolesnyk
requested changes
Feb 3, 2020
docs/page.md
Outdated
| @@ -157,6 +158,7 @@ A section is a reusable piece or part of a page. | |||
|
|
|||
| Attributes|Type|Use|Description | |||
| ---|---|---|--- | |||
| `deprecated`|string|optional|Used to warn about the future deprecation of the section. String will appear in Allure reports and console output at runtime. | |||
There was a problem hiding this comment.
Section reference in page do not have deprecated attr
It is only available under Section entity.
There was a problem hiding this comment.
Please remove this from Page doc. This attr not exist here.
docs/data.md
Outdated
| @@ -208,6 +208,7 @@ Attributes|Type|Use|Description | |||
| ---|---|---|--- | |||
| `key`|string|optional|Key attribute of data/value pair. | |||
| `unique`|enum: `"prefix"`, `"suffix"`|optional|Add suite or test wide unique sequence as "prefix" or "suffix" to the data value if specified. | |||
| `deprecated`|string|optional|Used to warn about the future deprecation of the data entity. String will appear in Allure reports and console output at runtime. | |||
There was a problem hiding this comment.
Please move this to entity tag description
okolesnyk
requested changes
Feb 4, 2020
There was a problem hiding this comment.
2 small comments
- please add deprecation attr to https://github.com/magento/magento2-functional-testing-framework/blob/develop/docs/metadata.md#operation-operation-tag
- Remove deprecated attr from page.md file under section tag
…functional-testing-framework into db_deprecation
okolesnyk
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds information about the new
deprecationtag.Fixed Issues (if relevant)
Contribution checklist