Skip to content

Conversation

@lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jan 28, 2020

Description (*)

This PR contains all other changes I introduced to MFTF and some more:

  • Unified stepKey to be camelCase (lower first)
  • Added ActionGroup suffix to all Action Groups
  • Updated documentation to follow best practices

Fixed Issues (if relevant)

  1. [ MFTF ] Mess in ActionGroups: invalid names, multiple nodes. magento2#26331

Manual testing scenarios (*)

Run MFTF tests for:

Related Pull Requests

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lbajsarowicz
Copy link
Contributor Author

@magento run Travis CI - Pull Request

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@okolesnyk okolesnyk self-requested a review February 3, 2020 15:43
@lbajsarowicz
Copy link
Contributor Author

We won't be able to do it in one PR.
Before things get merged, we have hundreds of conflicts :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Mediotype partners-contribution Pull Request is created by Magento Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants