Skip to content

Updates include path to data file #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 2, 2020
Merged

Updates include path to data file #531

merged 5 commits into from
Jan 2, 2020

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Dec 13, 2019

Description

This PR updates the path to the data file include on devdocs to be consistent with other files.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@dobooth dobooth added the accept label Dec 13, 2019
@dobooth dobooth self-assigned this Dec 13, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 53.172% when pulling 9d85f41 on magento-devdocs:db_functional_update into 4f482ce on magento:master.

@coveralls
Copy link

coveralls commented Dec 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 52.838% when pulling 9d85f41 on magento-devdocs:db_functional_update into 4f482ce on magento:master.

@dobooth dobooth removed the accept label Dec 13, 2019
@dobooth dobooth changed the title Db functional update Updates include path to data file Dec 13, 2019
KevinBKozan
KevinBKozan approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge to master when you need to (if coordination is required).

@dobooth dobooth mentioned this pull request Dec 13, 2019
Merged
@dobooth dobooth added the DOC label Jan 2, 2020
@okolesnyk okolesnyk merged commit 2805f11 into magento:master Jan 2, 2020
@dobooth dobooth deleted the db_functional_update branch February 3, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees

@dobooth dobooth

Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dobooth @coveralls @KevinBKozan @okolesnyk