Skip to content

MQE-1917: ENABLE_BROWSER_LOG = false attaches JS logs to allure #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

MQE-1917: ENABLE_BROWSER_LOG = false attaches JS logs to allure #527

merged 1 commit into from
Dec 9, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Dec 9, 2019

Fix for ENABLE_BROWSER_LOG=false not turning off logging.

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 53.418% when pulling 9cd8891 on MQE-1917 into 8774ac6 on MFTF2.5.4-RC.

@coveralls
Copy link

coveralls commented Dec 9, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 52.918% when pulling 9cd8891 on MQE-1917 into 8774ac6 on MFTF2.5.4-RC.

@soumyau soumyau merged commit 245e116 into MFTF2.5.4-RC Dec 9, 2019
@soumyau soumyau deleted the MQE-1917 branch April 30, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @KevinBKozan