Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE-843: Nested Assertion syntax does not support entity resolution #52

Merged
merged 3 commits into from
Mar 12, 2018
Merged

MQE-843: Nested Assertion syntax does not support entity resolution #52

merged 3 commits into from
Mar 12, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Mar 12, 2018 •
edited
Loading

Description

  • changed order of assertionAttribute flattening to happen before resolution of entities.

Fixed Issues (if relevant)

  1. MFTF-33305: Eliminate AspectMock from ObjectExtensionUtilTest #843: Nested Assertion syntax does not support entity resolution

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-843: Nested Assertion syntax does not support entity resolution
9423502 
- nested assertions now trim in the correct order, and replace as expected.
@KevinBKozan
MQE-843: Nested Assertion syntax does not support entity resolution
e0aaf6a 
- bugfix for sortOrder in assertArrayIsSorted.
@KevinBKozan
Merge branch 'develop' into MQE-843
e3ea48b
@KevinBKozan KevinBKozan merged commit f3a02c3 into develop Mar 12, 2018
@KevinBKozan KevinBKozan deleted the MQE-843 branch March 12, 2018 18:11
magento-cicd2 pushed a commit that referenced this pull request May 5, 2021
@okolesnyk
Merge pull request #52 from magento-commerce/MQE-2641
5a6bdf5 
Mqe 2641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevinBKozan