Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE-841: robo generate:tests --force should not require MAGENTO_BASE_URL #48

Merged
merged 5 commits into from
Mar 9, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Mar 9, 2018

Description

Using --force flag now allows users to generate tests regardless if their .env has MAGENTO_BASE_URL defined, or defined as ''.

Fixed Issues (if relevant)

  1. 33307: Eliminated AspectMock usage from GenerationErrorHandlerTest.php #841: robo generate:tests --force should not require MAGENTO_BASE_URL

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan KevinBKozan merged commit 0a7e06a into develop Mar 9, 2018
@KevinBKozan KevinBKozan deleted the MQE-841 branch March 9, 2018 17:38
magento-cicd2 pushed a commit that referenced this pull request Apr 6, 2021
3.5.0 Change log, version bump to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant