Skip to content

Bugfix: PHP Fatal error: MftfApplicationConfig not found in GenerateSuiteCommand #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

magicsunday
Copy link

@magicsunday magicsunday commented Sep 27, 2019

Description

Fixed Issues (if relevant)

  1. PHP Fatal error: MftfApplicationConfig not found in GenerateSuiteCommand #471: PHP Fatal error: MftfApplicationConfig not found in GenerateSuiteCommand
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Sep 27, 2019

CLA assistant check
All committers have signed the CLA.

@magicsunday magicsunday changed the title This fixes #471 Bugfix: PHP Fatal error: MftfApplicationConfig not found in GenerateSuiteCommand Sep 27, 2019
@KevinBKozan
Copy link
Contributor

@magicsunday Thank you for your submission! We'll keep you updated with PR progress as it we review your code.

@tomreece
Copy link
Contributor

This was fixed in #478 and has been released in the MFTF 2.5.1 tag.

@tomreece tomreece closed this Oct 10, 2019
@magicsunday magicsunday deleted the patch-1 branch October 11, 2019 08:42
@magicsunday
Copy link
Author

Why another pull request with the same fix?

@tomreece
Copy link
Contributor

I didn't realize there was both an Issue and a PR for this fix. So I read the issue, fixed it, and then discovered this PR after the fact.

@okolesnyk
Copy link
Member

Hi @magicsunday
Sorry for inconvenience. We just wanted to deliver fix very fast and we missed your PR.
If you wish you can reopen your PR so then we will merge it and you work is not lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants