Skip to content

Fixed example test cases to point to actual tests #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

lfolco
Copy link
Contributor

@lfolco lfolco commented Sep 15, 2019

Description

The example test cases do not exist and will give an error when you try to run them.

Fixed Issues (if relevant)

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Sep 15, 2019

Coverage Status

Coverage decreased (-2.5%) to 51.974% when pulling 26558bf on lfolco:patch-1 into d9de524 on magento:master.

@KevinBKozan
Copy link
Contributor

Hello @lfolco thank you for your submission! We've created an internal ticket to track your PR's progress, and we'll keep you updated via this PR.

@dobooth dobooth added the DOC label Oct 14, 2019
@KevinBKozan
Copy link
Contributor

Closing and reopening to refresh Adobe CLA check

@KevinBKozan KevinBKozan reopened this Oct 18, 2019
@KevinBKozan KevinBKozan merged commit a7997d9 into magento:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants