Skip to content

MQE-1715: .credentials file must exist but it should not have to #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2019
Merged

MQE-1715: .credentials file must exist but it should not have to #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf88ed
MQE-1715: .credentials file must exist but it should not have to
KevinBKozan Aug 30, 2019
9015ee9
MQE-1715: .credentials file must exist but it should not have to
KevinBKozan Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Magento Functional Testing Framework Changelog
================================================

2.4.5
-----
### Fixes
* Fixed an issue where `.credentials` was required when using `<createData>` actions with field overrides.

2.4.4
-----
### Fixes
Expand Down
2 changes: 1 addition & 1 deletion bin/mftf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ try {
try {
$application = new Symfony\Component\Console\Application();
$application->setName('Magento Functional Testing Framework CLI');
$application->setVersion('2.4.4');
$application->setVersion('2.4.5');
/** @var \Magento\FunctionalTestingFramework\Console\CommandListInterface $commandList */
$commandList = new \Magento\FunctionalTestingFramework\Console\CommandList;
foreach ($commandList->getCommands() as $command) {
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "magento/magento2-functional-testing-framework",
"description": "Magento2 Functional Testing Framework",
"type": "library",
"version": "2.4.4",
"version": "2.4.5",
"license": "AGPL-3.0",
"keywords": ["magento", "automation", "functional", "testing"],
"config": {
Expand Down
2 changes: 1 addition & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/PersistedObjectHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

use Magento\FunctionalTestingFramework\DataGenerator\Persist\DataPersistenceHandler;
use Magento\FunctionalTestingFramework\Exceptions\TestReferenceException;
use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;

class PersistedObjectHandler
{
Expand Down Expand Up @@ -86,7 +87,12 @@ public function createEntity(
}

foreach ($overrideFields as $index => $field) {
$overrideFields[$index] = CredentialStore::getInstance()->decryptAllSecretsInString($field);
try {
$overrideFields[$index] = CredentialStore::getInstance()->decryptAllSecretsInString($field);
} catch (TestFrameworkException $e) {
//do not rethrow if Credentials are not defined
$overrideFields[$index] = $field;
}
}

$retrievedEntity = DataObjectHandler::getInstance()->getObject($entity);
Expand Down