Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE-802: Make ActionObject list of allowed characters comprehensive #42

Merged
merged 4 commits into from
Feb 28, 2018
Merged

MQE-802: Make ActionObject list of allowed characters comprehensive #42

merged 4 commits into from
Feb 28, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Feb 27, 2018 •
edited
Loading

Description

  • Characters in parameterized selectors/urls are now comprehensive, only disabled char is ' due to delimiter need.
  • Added sanitization check for Page/Section/Element/Data names

Fixed Issues (if relevant)

  1. Mqe 2133 2140 #802: Make ActionObject list of allowed characters comprehensive

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-802: Make ActionObject list of allowed characters comprehensive
3632568 
- changed actionObject to use two patterns for replacement: (word.word and word.word(anycharacters)). Fixes the blacklist problem.
- added check for alphanumeric/underscore naming in various objects.
- added sanitization of parameters, so that commas can now be used in 'stringliteral'
@KevinBKozan
MQE-802: Make ActionObject list of allowed characters comprehensive
07fe3e9 
- Changed delimiter from ', ', to '::::'
@KevinBKozan
MQE-802: Make ActionObject list of allowed characters comprehensive
23556f4 
- CR Fix
@KevinBKozan
Merge branch 'develop' into MQE-802
1c18d35
@KevinBKozan KevinBKozan merged commit f03f1e1 into develop Feb 28, 2018
@KevinBKozan KevinBKozan deleted the MQE-802 branch February 28, 2018 14:32
magento-cicd2 pushed a commit that referenced this pull request Mar 30, 2021
@jilu1
Merge pull request #42 from magento-commerce/2.7.1-RC
4802c67 
MQE-2607: changelog.md and version bump for 2.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevinBKozan