Skip to content

Removed unused variables in FunctionCommentSniff.php #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2018

Conversation

gy741
Copy link
Contributor

@gy741 gy741 commented Oct 26, 2018

Description

Hello,

I have remove unused variable.

Because it is not used.

What do you think of it?

Thanks.

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.482% when pulling d6e0b77 on gy741:remove_dead_code_v2 into 4c8b297 on magento:develop.

@coveralls
Copy link

coveralls commented Oct 26, 2018

Coverage Status

Coverage increased (+0.008%) to 57.054% when pulling 1f780e7 on gy741:remove_dead_code_v2 into bf2143d on magento:develop.

@KevinBKozan
Copy link
Contributor

@gy741 Thank you for your contribution! We will update this PR with progress information as we process it.

@okolesnyk okolesnyk self-requested a review November 20, 2018 15:59
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gy741 Please take a look at comment I left.

@okolesnyk okolesnyk merged commit ce9ea48 into magento:develop Dec 10, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Jan 4, 2023
Merging master back to develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants