Skip to content

MQE-1040: MFTF standalone commands do not pass down constants correctly #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2018
Merged

MQE-1040: MFTF standalone commands do not pass down constants correctly #232

merged 2 commits into from
Sep 20, 2018

Conversation

aljcalandra
Copy link
Contributor

  • Corrected original ticket
  • Changed functional run location from alternate Magento Directory to project directory whether standalone or in vendor

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@aljcalandra
MQE-1040: MFTF standalone commands do not pass down constants correctly
4651c9c 
- Corrected original ticket
- Changed functional run location from alternate Magento Directory to project directory whether standalone or in vendor
@aljcalandra
MQE-1040: MFTF standalone commands do not pass down constants correctly
270c5bb 
- Removing commented line
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.398% when pulling 270c5bb on MQE-1040 into 66b6ecd on develop.

@coveralls
Copy link

coveralls commented Sep 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 57.398% when pulling 270c5bb on MQE-1040 into 66b6ecd on develop.

KevinBKozan
KevinBKozan approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, ran standalone pointed at a Magento instance we had no issues.

@aljcalandra aljcalandra merged commit 10a269e into develop Sep 20, 2018
@aljcalandra aljcalandra deleted the MQE-1040 branch September 20, 2018 18:08
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 26, 2022
@jilu1
Merge pull request #232 from magento-gl/3.11.0-RC
53d13c0 
ACQE-4111 : 3.11.0 Deployment Release Checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljcalandra @coveralls @KevinBKozan