Skip to content

MQE-1040: MFTF standalone commands do not pass down constants correctly #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2018

Conversation

aljcalandra
Copy link
Contributor

Adjusted bootstrap files to allow alternative Magento installation locations relative to MFTF

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Updated Magento_bp and Tests_bp to be set after env is loaded
- Updated standalone bootstrap to use different relative module path if magento_bp is set
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.191% when pulling 38295a4 on MQE-1040 into b4a27e5 on develop.

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem to work well.
There is a concern over MAGENTO_BP being set the same as PROJECT_BP in the normal bootstrap, but that was not introduced as part of your change.

@aljcalandra aljcalandra merged commit 66b6ecd into develop Sep 18, 2018
@aljcalandra aljcalandra deleted the MQE-1040 branch September 18, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants