MQE-1040: MFTF standalone commands do not pass down constants correctly #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Magento_bp and Tests_bp to be set after env is loaded - Updated standalone bootstrap to use different relative module path if magento_bp is set
- Updated filename
- Changed define to add defined
KevinBKozan
approved these changes
Sep 18, 2018
Contributor
KevinBKozan
left a comment
KevinBKozan
left a comment
There was a problem hiding this comment.
Changes seem to work well.
There is a concern over MAGENTO_BP being set the same as PROJECT_BP in the normal bootstrap, but that was not introduced as part of your change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted bootstrap files to allow alternative Magento installation locations relative to MFTF
Contribution checklist