Skip to content

Conversation

@jilu1
Copy link
Contributor

@jilu1 jilu1 commented Sep 13, 2018

Description

MQE-1142: Use timeout value when waitForLoadingMaskToDisappear

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Sep 13, 2018

Coverage Status

Coverage decreased (-0.008%) to 57.151% when pulling f267432 on MQE-1142 into 31ddcc8 on develop.

@KevinBKozan KevinBKozan changed the title [2.3.7] Bug fix MQE-1142: Use timeout value when waitForLoadingMaskToDisappear MQE-1142: Use timeout value when waitForLoadingMaskToDisappear Sep 14, 2018
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete, confirmed this works for passing down timeout in execution.

@jilu1 jilu1 merged commit c4d3307 into develop Sep 18, 2018
@jilu1 jilu1 deleted the MQE-1142 branch November 6, 2018 17:26
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 20, 2022
ACQE-4122: fixed an issue in test generation with config parallel by …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants