MQE-1065: Persisted data are not resolved correctly when using with ParameterArray #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameterArray - bug fix
…arameterArray - addressed static test failures
jilu1
changed the title
jilu1
changed the title
KevinBKozan
suggested changes
Sep 14, 2018
| $arrayResult = []; | ||
| $count = 0; | ||
|
|
||
| // matches arrays |
There was a problem hiding this comment.
I think we need a little more commenting on here, what's actually happening is more like
find arrays, replace them with placeholder to prevent manipulation in foreach below
| preg_match_all('/[\[][^\]]*?[\]]/', $input, $paramInput); | ||
| if (!empty($paramInput)) { | ||
| foreach ($paramInput[0] as $param) { | ||
| $arrayResult[static::PRESSKEY_ARRAY_ANCHOR_KEY . $count] = |
There was a problem hiding this comment.
We call class constants as self::CONSTANT_NAME everywhere else in the framework, may be worth doing the same here.
| } | ||
|
|
||
| $result = implode(',', $result); | ||
| if (!empty($arrayResult)) { |
There was a problem hiding this comment.
Comment here:
Reinsert arrays into result
…arameterArray - addressed review comments
KevinBKozan
approved these changes
Sep 14, 2018
KevinBKozan
changed the title
|
@jilu1 changes are good to go. I changed the title of the PR to conform to normal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MQE-1065: Persisted data are not resolved correctly when using with ParameterArray
Contribution checklist