Skip to content

Support PHP-FPM in command.php #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

nathanjosiah
Copy link
Contributor

@nathanjosiah nathanjosiah commented Aug 30, 2018

Remove assumption that PHP_BINARY will always be acceptable.

Description

command.php assumes that if PHP_BINARY is set that it is always the PHP cli bin. When FPM is used, the bin will be php-fpm which isn't compatible with the PHP cli. This PR removes that constant and instead uses the already present PHP_BINDIR usage

Fixed Issues (if relevant)

  1. command.php assumes that PHP_BINARY is always the PHP cli binary #216: command.php assumes that PHP_BINARY is always the PHP cli binary

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Aug 30, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.092% when pulling 4328833 on magento-trigger:fpm-compatibility into e187c33 on magento:develop.

@KevinBKozan
Copy link
Contributor

@nathanjosiah Thank you for your contribution! We will update this PR with progress information as we process it.

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I can confirm that this command.php change does not affect non-valet setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants