Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove assumption that
PHP_BINARY
will always be acceptable.Description
command.php
assumes that ifPHP_BINARY
is set that it is always the PHP cli bin. When FPM is used, the bin will bephp-fpm
which isn't compatible with the PHP cli. This PR removes that constant and instead uses the already presentPHP_BINDIR
usageFixed Issues (if relevant)
Contribution checklist