MFTF 2.3.4 Merge develop to master #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added null check for getDriver
- Updated null check
- Added null check for error on after step
- Removed catches, removed line from functional suite yml
- changelog entry for 2.3.4 added - version bump in composer and lock file
- reintroduced functional.suite.dist.yml restart: true - MagentoWebDriver overwrites parent _after function and remaps it (to be called in TestContextExtension
- Static check ignore for PHPMD
- Moved reset session to after all test runs - changed suites to not run suite_after if last test was a failure (compatibility issues)
- Suite After no longer resets WebDriver, allows Test after to fail naturally (and Suite After to run)
- Unit test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist