[Pangolin] Deliver changes from Sprint 14 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fail gracefully if Magento is not running
- Do not error when Data, Section, or Page XML does not exist
…n selector - Changed str_replace to preg_replace, regex disallows replacement when the argument is attached to another word (cases like categorySideButton versus category.name) - Added Verification test for useCase
…test composer.json - add new test actions type - updated verification tests to include check for actionGroup in hook type
- Do not blow up if admin username or admin password not set in .env file
- Adding the "assertElementContainsAttribute" method to the MagentoWebDriver file.
- Adding the "assertElementContainsAttribute" method to the Test Schema.
- Adding the "assertElementContainsAttribute" method to the di.xml so it can be listed multiple times in a test.
- Adding the "assertElementContainsAttribute" method to the MagentoWebDriver.php file.
- Adding verification tests.
- Expanding comments for the function to make it clearer.
- Replaced "userInput" with "expectedValue".
- Adding "expectedValue" to the TestGenerator.
- updated composer to pull phpmd, ported Magento rulesets to work with phpmd on MFTF - updated static-checks with PHPMD, no changes to devops required - commented Mess Detector Lines out to enable them during MQE-590
…ng masks match the same selector - Added parenthesis according to the AC.
- addressed all base AC of issue. - Broke out sanitization into its own method, defined _resetConfig to prevent variables from being overwritten on test startup. - Added step to configure rest URL based on sanitized version of MAGENTO_BASE_URL.
…ibute rule checks in test generator.
- Copy readme from tests (magento2) repo - Add extension to license to make opening easier
…onal-testing-framework into sprint-develop
- add new removal action - add new deprecation message for incorrect usage of removal attribute - update verification tests
- removing reference to remove attribute
- fix codesniffer error from static check
…ibute rule checks in test generator.
…ibute rule checks in test generator.
# Conflicts: # dev/tests/verification/TestModule/ActionGroup/MergeFunctionalActionGroup.xml # dev/tests/verification/TestModule/Cest/MergeInFunctionalCest.xml # etc/di.xml # src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd
- replace hardcoded dir references with DIRECTORY_SEPARATOR constant
- changes to test suite in order to account for os pathing in verification tests - add .gitattributes to the mftf
# Conflicts: # src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd
- Adding a call to the "closeAdminNotification" function, because Admin notifications randomly appear after some tests due to Cache Management.
- Removing the PhantomJS yml file because the PhantomJS project is not maintained.
- add changes for MagentoWebDriver wait and pageload timeout settings
…onal-testing-framework into sprint-develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Stories
Bugs
Related Pull Requests
https://github.com/magento/magento2ce/pull/1813
https://github.com/magento/magento2ee/pull/809
https://github.com/magento/magento2b2b/pull/319
Checklist
Created by : @okolesnyk
Internal PR: https://github.com/magento-pangolin/magento2-functional-testing-framework/pull/42