Skip to content

MQE-992: Allow Tests and Action Groups to use inheritance #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 17, 2018
Merged

Conversation

aljcalandra
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

aljcalandra added 20 commits May 8, 2018 13:22
- Added Action Group and moved inheritance to getObject calls in the handlers
- Added index to actions
- Updated unit test appropriately
- Fixed docstrings and use(s)
- Moved some functionality for extending groups
- Added Verification Tests
- Added Hooks to Test Extension
- Updated a docstring for hook array
- Added ObjectExtension Unit Tests
- Updated ArrayBuilders
- Added unit tests
- Updated and split out verification tests
- Updated docstrings
- Added method for getting raw parsed steps to Test Object
- Added Comments to ObjectExtension
- Updated class variable docstring
- Removed unused verification resource
- Added capture for output string for unit test
- Changed ObjectExtionsion to add Util
- Added Constructor and updated methods to non-static
- updated indexes
- Added support for Remove actions
- Added more verification and unit tests
- Refactored one long function
- Cleaned up remove function
- Removed throw
- Set stepKey differently for remove type actions
- Removed commentd line
- moved creation of ObjectExtension object to class property
- Added functionality for removing actions from within test hooks
- Made change to order for actions in action groups when resolving actions
# Conflicts:
#	dev/tests/unit/Util/TestDataArrayBuilder.php
#	src/Magento/FunctionalTestingFramework/Test/Objects/ActionGroupObject.php
#	src/Magento/FunctionalTestingFramework/Test/Util/ActionGroupObjectExtractor.php
#	src/Magento/FunctionalTestingFramework/Test/Util/TestObjectExtractor.php
#	src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd
#	src/Magento/FunctionalTestingFramework/Test/etc/mergedTestSchema.xsd
- Added warning instead of exception for non-existent parent tests
- Updated to only add skip to groups if it doesn't already exist
- Moved skipTest function to Object Extension Util
@coveralls
Copy link

coveralls commented May 17, 2018

Coverage Status

Coverage increased (+1.04%) to 58.368% when pulling b672a34 on MQE-992 into 1bedd14 on develop.

@aljcalandra aljcalandra merged commit 22a1ef1 into develop May 17, 2018
@aljcalandra aljcalandra deleted the MQE-992 branch May 17, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants