-
Notifications
You must be signed in to change notification settings - Fork 133
MQE-992: Allow Tests and Action Groups to use inheritance #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Test Inheritance
- Added Action Group and moved inheritance to getObject calls in the handlers - Added index to actions - Updated unit test appropriately
- Fixed docstrings and use(s) - Moved some functionality for extending groups
- Added Verification Tests - Added Hooks to Test Extension - Updated a docstring for hook array
- Added ObjectExtension Unit Tests - Updated ArrayBuilders
- Added unit tests - Updated and split out verification tests - Updated docstrings - Added method for getting raw parsed steps to Test Object - Added Comments to ObjectExtension
- Updated class variable docstring - Removed unused verification resource - Added capture for output string for unit test
- Changed ObjectExtionsion to add Util - Added Constructor and updated methods to non-static - updated indexes
- Added support for Remove actions - Added more verification and unit tests - Refactored one long function
- Cleaned up remove function - Removed throw - Set stepKey differently for remove type actions
- Removed commentd line - moved creation of ObjectExtension object to class property
Moved stepKey assignment to Flat
- Removed unused constant
- Added functionality for removing actions from within test hooks
- Made change to order for actions in action groups when resolving actions
# Conflicts: # dev/tests/unit/Util/TestDataArrayBuilder.php # src/Magento/FunctionalTestingFramework/Test/Objects/ActionGroupObject.php # src/Magento/FunctionalTestingFramework/Test/Util/ActionGroupObjectExtractor.php # src/Magento/FunctionalTestingFramework/Test/Util/TestObjectExtractor.php # src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd # src/Magento/FunctionalTestingFramework/Test/etc/mergedTestSchema.xsd
- Updated test for merged code
- Added warning instead of exception for non-existent parent tests
- Updated to only add skip to groups if it doesn't already exist
- Moved skipTest function to Object Extension Util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist